HI Daniel, On Mon, Mar 24, 2008 at 03:56:07AM -0400, Daniel Veillard wrote: > Hum, could you send those kind of patches as attachments in the future ? > Basically assuming spaces/tabs are correctly preserved in an email body is > taking unecessary risks. Also having a name for the patch and being able > to download them from on-line email archives is a good thing, O.k., fine. > Now for the content of the patch, it seems to remove all tabs and replace > them with 8 spaces. Is that really a better way, why use 8 characters when > you can use one for the same purpose ? One could argue either way, maybe No, it uses 4 spaces for each indentation level, this is what the other files I checked (mostly qemu_*.c, xml.c) use and remote_internal.c even has: /* * vim: set tabstop=4: * vim: set shiftwidth=4: * vim: set expandtab: */ which is basically what I used for reindenting virterror.c. So the patch is just to make things consistent with the rest of the c code. -- Guido -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list