On Fri, Mar 21, 2008 at 05:39:51PM +0000, Daniel P. Berrange wrote: > On Fri, Mar 21, 2008 at 01:29:07PM -0400, Daniel Veillard wrote: > > Another small issue is that I have the clone flags defined in > > <linux/sched.h> but not in <sched.h> so I had to add that include > > to get the module to compile, lxcCheckContainerSupport() check > > then passes on my Fedora-8 2.6.24 kernel. > > I filed > > https://bugzilla.redhat.com/show_bug.cgi?id=438542 > > to request the flags are added to sched.h too, but we should just #define > them in the driver as we do for Xen hypervisor constants. This avoids a > hard dependancy between the kernel used for compile, vs running. Is that really better than #include <linux/sched.h> ? That code is linux specific after all .. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list