On Fri, Mar 21, 2008 at 06:32:45PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > ... > > The following patches make the driver properly integrate with the stateful > > driver APIs. It also changes the config files to be named by on VM name > > instead of UUID, since this is what the QEMU driver does & its more user > > friendly. It also adds the CLONE_XXX constants since they have not yet > > been added to the libc sched.h file. IMHO we should enable the driver by > > default, since it can already probe for availability at runtime. Finally > > it also fixes a typo where it wrote 'linuxcontainer' as the domain type > > in the config file instead of 'lxc'. > ... > > Index: src/lxc_driver.c > > =================================================================== > > RCS file: /data/cvs/libvirt/src/lxc_driver.c,v > ... > > +static lxc_driver_t *lxc_driver; > > Do you really want to add a static variable to the library? Yes, this turns LXC into a stateful driver that lives in the context of the daemon only. This is the same way the QEMU / network drivers work. Regards, Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list