On Wed, Mar 19, 2008 at 11:55:54AM +0100, Jim Meyering wrote: > Hiroyuki Kaguchi <fj7025cf@xxxxxxxxxxxxxxxxx> wrote: > > Thank you for your suggestions. > > I apply the following changes to the patch. > > 1) Initialize errno to 0 before the loop. > > 2) Use isxdigit instead of isdigit and isalpha, and add a comment. > > 3) Test errno != 0. > > 4) Add a terminating NUL check. > > 5) the MAC address function go in file src/util.c. > > Looks good. A couple nits. > I didn't read the comments the first time. Okay, I have commited the suggested patch after applying the changes proposed by Jim, thanks a lot ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list