On Wed, Mar 19, 2008 at 04:07:34PM +0900, Hiroyuki Kaguchi wrote: > Hi, Jim and Rich > > Thank you for your suggestions. > I apply the following changes to the patch. > 1) Initialize errno to 0 before the loop. > 2) Use isxdigit instead of isdigit and isalpha, and add a comment. > 3) Test errno != 0. > 4) Add a terminating NUL check. > 5) the MAC address function go in file src/util.c. Yup, can't see anything wrong in that patch. +1 Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list