On Mon, Mar 03, 2008 at 12:29:50PM -0500, Cole Robinson wrote: > The patch below fixes the capabilities xml generated for the hosts > topology info. This was causing virt-install to barf when using > the test driver (see attached capabilities xml from before this patch). > > Thanks, > Cole > > diff --git a/src/capabilities.c b/src/capabilities.c > index bedd445..01bb308 100644 > --- a/src/capabilities.c > +++ b/src/capabilities.c > @@ -583,7 +583,7 @@ virCapabilitiesFormatXML(virCapsPtr caps) > caps->host.numaCell[i]->ncpus) < 0) > goto no_memory; > for (j = 0 ; j < caps->host.numaCell[i]->ncpus ; j++) > - if (virBufferVSprintf(&xml, " <cpu id='%d'>\n", > + if (virBufferVSprintf(&xml, " <cpu id='%d'/>\n", > caps->host.numaCell[i]->cpus[j]) < 0) > goto no_memory; > if (virBufferAddLit(&xml, " </cpus>\n") < 0) Sigh, really that couldn't generate well formed XML ! Thanks a lot for finding this ! I'm commiting this right now, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list