On Mon, Mar 03, 2008 at 11:50:30AM +0100, Jim Meyering wrote:
> Daniel Veillard <veillard@xxxxxxxxxx> wrote:
> ...
> Thanks for the quick feedback.
>
> > Okay, i would have checked caps->host.nmigrateTrans against NULL first
>
> If I were to do that, "make distcheck" would detect
> the redundant if-before-free and make the build fail.
My point is that if you access
caps->host.migrateTrans[i]
then you should make sure caps->host.migrateTrans is not NULL,
whether it's freed or not later is orthogonal.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list