"Richard W.M. Jones" <rjones@xxxxxxxxxx> wrote: > On Fri, Feb 29, 2008 at 12:59:39PM +0100, Jim Meyering wrote: >> diff --git a/src/util.c b/src/util.c >> index 4d61540..edaa5aa 100644 >> --- a/src/util.c >> +++ b/src/util.c >> @@ -35,6 +35,7 @@ >> #include <sys/stat.h> >> #include <sys/wait.h> >> #include <string.h> >> +#include <ctype.h> > > Anyway, +1 the patch looks fine. Hi Rich, Thanks for the review. > I thought we're not supposed to be using ctype? As far as i know, #include <ctype.h> is still the only way to use the things it specifies (tolower, isupper, isxdigit, etc.) Maybe you're thinking of strings.h? -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list