On Tue, Feb 26, 2008 at 12:01:04PM +0000, Richard W.M. Jones wrote: > On Tue, Feb 26, 2008 at 11:43:59AM +0100, Jim Meyering wrote: > > "Richard W.M. Jones" <rjones@xxxxxxxxxx> wrote: > > > This patch is an evolution of the previous patch for implementing DHCP > > ... > > > + if (maxmappings == 0) return 0; > > ... > > > + if (col == 0) hwaddr = token; > > ... > > > + if (!(*hwaddrs)[lines]) goto mem_error; > > > > Hi Rich, > > > > Is there a libvirt style convention that says whether > > a one-line if-block is written all on one line? > > I find it slightly easier to spot the conditional at a glance > > when the statement is on a separate line, but can certainly adapt > > to a different style. > > I don't know ... Is there a libvirt manual of style? I usually go to a separate line myself. I use the following: paphio:~ -> cat bin/cb #!/bin/sh indent -bad -bap -bbb -bli4 -br -ce -brs -cs -i4 -l75 -lc75 -nut -sbi4 -psl -saf -sai -saw -sbi4 -ss -sc -cdw -cli4 -npcs -nbc but I'm not sure there is an option for that (well I could not find it) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list