On Tue, Feb 12, 2008 at 04:33:42AM +0000, Daniel P. Berrange wrote:
> This extends the generator / manual bindings to implement all the
> storage APIs. Most are handle automatically, and those which are
> not, pretty much follow the existing pattern for virDomain and
> virNetwork APIs.
>
> generator.py | 93 +++++++++++++++++-
okay generator change are just related to more classes being defined
looks fine, +1
> diff -r 7e5658cc1a93 python/libvir.c
> +static PyObject *
> +libvirt_virConnectListStoragePools(PyObject *self ATTRIBUTE_UNUSED,
> + PyObject *args) {
[...]
> +}
> +
> +
> +static PyObject *
> +libvirt_virConnectListDefinedStoragePools(PyObject *self ATTRIBUTE_UNUSED,
> + PyObject *args) {
[...]
> +}
> +
> +
> +static PyObject *
> +libvirt_virStoragePoolListVolumes(PyObject *self ATTRIBUTE_UNUSED,
> + PyObject *args) {
[...]
> +}
okay functions needed to return lists objects, looks fine
> +static PyObject *
> +libvirt_virStoragePoolGetInfo(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) {
> +}
[...]
> +
> +
> +static PyObject *
> +libvirt_virStorageVolGetInfo(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) {
that too
> +}
> +
> +static PyObject *
> +libvirt_virStoragePoolGetUUID(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) {
UUID argument OUT
> +}
> +
> +
> +static PyObject *
> +libvirt_virStoragePoolLookupByUUID(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) {
UUID argument IN
> +}
> +
> +
>
> /************************************************************************
> * *
> @@ -1131,6 +1416,14 @@ static PyMethodDef libvirtMethods[] = {
registration
> diff -r 7e5658cc1a93 python/libvirt_wrap.h
> --- a/python/libvirt_wrap.h Thu Feb 07 12:33:22 2008 -0500
> +++ b/python/libvirt_wrap.h Thu Feb 07 12:33:27 2008 -0500
and more wrappers, okay look fine, all make sense.
+1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list