On Thu, Feb 14, 2008 at 12:15:26PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > > > I tried to apply all of these patches, and ended up with a bunch of > failed hunks. For example, the one above fails due to the fact that > there is no "jobs" member in checked-in sources, yet the patch > requires that it be there in the existing context. Urgh, yes. I forgot to mention that these were diffed wrt to the jobs patches. For convenience just apply the patches from the patch queue http://hg.berrange.com/libraries/libvirt--storage Where the 'series' file gives the canonical order. > I'm not too worried about the .xml or even .py conflicts, for now. > The failed hunks in virsh.c all involve VIR_JOB_CANCELLED, so I suspect > that the failures are all ignorable. > > Bottom line: looked problematic, but no big deal I'd like to add the storage API before the job stuff, because there's a couple of tweaks to the job stuff needed to make it work more easily with the storage APIs. So I'll re-diff the patches so the storage APIs apply first. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list