Jim Meyering <jim@xxxxxxxxxxxx> wrote:
> A few new uses of already-checked functions were added recently,
> and I've added xmlXPathFreeObject to the list, so that exposed
> a bunch more.
>
> -----------------------------------------------------------
> Remove more useless if tests before "free"-like functions.
>
> * build-aux/useless-if-before-free: Rename from ...
> * build-aux/find-unnecessary-if-before-free: ... this. Remove file.
> Also changed it so that new names are no longer hard-coded in the
> script. Instead, they're supplied via options:
> * Makefile.cfg (useless_free_options): Define.
> Add xmlXPathFreeObject to the list of free-like functions it detects.
> * Makefile.maint (sc_avoid_if_before_free): Reflect script renaming.
...
> diff --git a/Makefile.maint b/Makefile.maint
> index 923c422..8624328 100644
> --- a/Makefile.maint
> +++ b/Makefile.maint
> @@ -40,7 +40,8 @@ syntax-check: $(local-check)
> ## --------------- ##
>
> sc_avoid_if_before_free:
> - @$(srcdir)/build-aux/find-unnecessary-if-before-free \
> + @$(srcdir)/build-aux/useless-if-before-free \
> + $(useless_free_options) \
> $$($(CVS_LIST_EXCEPT)) && \
> { echo '$(ME): found useless "if" before "free" above' 1>&2; \
> exit 1; } || :
> @@ -288,7 +289,7 @@ sc_two_space_separator_in_usage:
> 1>&2; exit 1; } || :
>
> err_func_re = \
> -(DISABLE_fprintf|(xmlRpc|vir(Xend|XML|Hash|Conf|Test|LibConn))Error)
> +(DISABLE_fprintf|qemudLog|(xmlRpc|vir(Xend|XML|Hash|Conf|Test|LibConn))Error)
Whoops.
That latter hunk doesn't belong in that patch.
I've just removed it locally.
FYI, I'm in the process of marking-for-translation all qemudLog diagnostics.
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list