Re: [PATCH] for MinGW Re: Pthreads error in windows compilation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Atsushi SAKAI wrote:
Hi,

 Today I recognized.
It would be better to write #include <pthread.h> in hash.h than hash.c.
And compilation works if configure.in changes in MINGW?
Would you apply this patch?

I think actually it's better to push the '#include <pthread.h>' all the way up into src/internal.h. It's required in other places, eg. in src/libvirt.c.

However, the biggest problem I have is I don't have pthread.h in MinGW. Where do you get pthread from for MinGW?

About the other part of this patch:

-    MINGW_EXTRA_LDFLAGS="-no-undefined"
+    MINGW_EXTRA_LDFLAGS="-lintl -lpthreadGC2"

'-no-undefined' is required in order to get libtool to build a DLL.

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]