"Richard W.M. Jones" <rjones@xxxxxxxxxx> wrote: > Jim Meyering wrote: >> - error (flags & REMOTE_CALL_IN_OPEN ? NULL : conn, VIR_ERR_RPC, "xdr_int (length word)"); >> + error (flags & REMOTE_CALL_IN_OPEN ? NULL : conn, VIR_ERR_RPC, _("xdr_int (length word)")); > > +1 to the patch, but I wonder what translators will make of errors > like the one above, particularly since the po file gives them almost > no context to work with. I agree in principle, but any clueful translator will be using tools that can easily display code context for the message they're considering. E.g., run this: info gettext 'C sources' -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list