As pointed by Jay Gagnon on IRC, virDomainGetXMLDesc() was failing if the flags value was non-NULL, and looking at the source we still had a check there to fail if flags is non-zero (and we define 2 flags in virDomainXMLFlags, so this is clearly broken), Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Index: src/libvirt.c =================================================================== RCS file: /data/cvs/libxen/src/libvirt.c,v retrieving revision 1.114 diff -u -r1.114 libvirt.c --- src/libvirt.c 21 Jan 2008 16:29:10 -0000 1.114 +++ src/libvirt.c 24 Jan 2008 14:31:14 -0000 @@ -1838,10 +1838,6 @@ virLibDomainError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__); return (NULL); } - if (flags != 0) { - virLibDomainError(domain, VIR_ERR_INVALID_ARG, __FUNCTION__); - return (NULL); - } conn = domain->conn;
-- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list