Daniel Veillard wrote:
dnl Do we have rpcgen? AC_PATH_PROG(RPCGEN, rpcgen, no) @@ -621,8 +625,8 @@ [enableval=no])if test "${enableval}" = yes; then- gl_COMPILER_FLAGS(-fprofile-arcs) - gl_COMPILER_FLAGS(-ftest-coverage) + dnl gl_COMPILER_FLAGS(-fprofile-arcs) + dnl gl_COMPILER_FLAGS(-ftest-coverage)We really shouldn't assume such recent features of gcc, I understand it's useful from for coverage reports, but it really can't get in the way for normal compilations, maybe this need to be refined a bit so that we can keep it. I would have assumed that if --enable-test-coverage wasn't explicitely asked for, then those bits would not need to be disabled, right ?
Yes, but unfortunately it doesn't work. Because gl_COMPILER_FLAGS isn't expanded in the output, ./configure fails even though the code is in a conditional arm. Bourne shell just can't parse it.
The problem seems to come about because aclocal doesn't put gl_COMPILER_FLAGS into aclocal.m4, and that is apparently because autom4te doesn't believe that gl_COMPILER_FLAGS is really used.
I don't know how to solve this -- I just commented it out so I could get it to work at all.
=================================================================== RCS file: /data/cvs/libvirt/src/Makefile.am,v retrieving revision 1.62 diff -u -r1.62 Makefile.am --- src/Makefile.am 5 Jan 2008 16:06:36 -0000 1.62 +++ src/Makefile.am 23 Jan 2008 13:21:44 -0000 @@ -66,7 +66,7 @@ libvirt_la_SOURCES = $(CLIENT_SOURCES) $(SERVER_SOURCES) libvirt_la_LIBADD = $(LIBXML_LIBS) $(GNUTLS_LIBS) $(SASL_LIBS) \ @CYGWIN_EXTRA_LIBADD@ ../gnulib/lib/libgnu.la -libvirt_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libvirt_sym.version \ +libvirt_la_LDFLAGS = \ -version-info @LIBVIRT_VERSION_INFO@ \ $(COVERAGE_CFLAGS:-f%=-Wc,-f%) \ @CYGWIN_EXTRA_LDFLAGS@ @MINGW_EXTRA_LDFLAGS@Hum, we really rely on libvirt_sym.version to define the exported list, someone may be able to help on how to do this on OS X, but as is we can't apply it seems.
Yeah, I don't know how to fix this yet on Mac OS X.It's possible we could just do some $host checking in ./configure and disable this bit of the command line for anything which matches *darwin*.
I'll commit the non-controversial parts of this patch. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
-- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list