On Sat, Jan 19, 2008 at 01:19:35PM +0000, Richard W.M. Jones wrote: > Another thing is that there's confusion over where 'flags' parameters > should be unsigned or not. The confusion comes from existing calls > which are a bit of a hodge-podge, even using 'long' in one case: > > virConnectOpenAuth int flags > virDomainCreateLinux unsigned int flags > virDomainCreateLinuxJob unsigned int flags > virDomainReboot unsigned int flags > virDomainCoreDump int flags > virDomainCoreDumpJob int flags > virDomainGetXMLDesc int flags > virDomainCreateJob int flags > virDomainMigrate unsigned long flags > virNetworkGetXMLDesc int flags > virConnectDiscoverStoragePools unsigned int flags > virStoragePoolRefresh unsigned int flags > virStoragePoolGetXMLDesc int flags > virStorageVolCreateXML int flags > virStorageVolGetXMLDesc int flags > > I propose that we change all except virDomainMigrate to 'unsigned int'. > That shouldn't break ABI (right?) Yeah, I don't believe it would break anything - easy enough to check by changing it and seeing if all our various apps still compile OK. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list