On Tue, Jan 15, 2008 at 09:31:28AM +0000, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >An off-by-one error in the remote driver checking for malloc() failure > >in the SSH argv meant all SSH connections were always rejected. It was > >always checking the trailing NULL in the argv[] > > Strange, I wonder when that happened ... I was using an ssh tunnel only > the other day. Yeah, I use it quite often too - guess I was unlucky and always using the SSH tunnelling on boxes with the Fedora libvirt RPMs, rather than on my dev boxes with CVS libvirt. Anyway, now committed. When DV returns we should probably aim to put out a 0.4.1 release because there have been a number of annoying bugs in 0.4.0 which we've sorted out. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list