On Mon, Jan 14, 2008 at 08:40:35AM +0000, Mark McLoughlin wrote: > Hey, > There's a few more obvious things missing, I think - e.g. should new > code use lower_case_with_underscores naming style or mixedCase ? Really ? About 70% of our code currently uses mixed case, no underscores. The QEMU/network driver file & mdns file are the main ones which don't. > On Sun, 2008-01-13 at 17:39 +0000, Daniel P. Berrange wrote: > > 2. Do not use conditionals in front of 'free'. > > > > eg Instead of > > > > if (foo) free(foo) > > > > Use > > > > free(foo) > > That's only safe with glibc, right ? The man page says its C89 standard and the nice folks at Wine have done some background checks which show its safe on any modern UNIX... http://www.winehq.org/pipermail/wine-patches/2006-October/031544.html Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list