On Mon, Jan 14, 2008 at 02:00:36PM +0100, Jim Meyering wrote: > "Richard W.M. Jones" <rjones@xxxxxxxxxx> wrote: > > Mark McLoughlin wrote: > >> Hi Rich, > >> > >> On Mon, 2008-01-14 at 12:13 +0000, Richard W.M. Jones wrote: > >> > >>> Just a minor nit here: My reading of the autoconf info page is that > >>> this should be a --with argument, not an --enable argument. > >> > >> I don't mind either way, but my understanding was that --with would > >> only be appropriate if we were doing: > >> > >> --with-lokkit=/usr/sbin/lokkit > >> > >> i.e. that --with was used for specifying the location of some external > >> dependency, whereas --enable is used for simply enabling or disabling a > >> feature. > > > > You could be right. > > > > /me invokes Jim Meyering > > ... https://www.redhat.com/archives/libvir-list/2008-January/msg00126.html > > Hi guys, > > You probably know that --with-THING and --enable-THING are functionally > equivalent, and the question is about which should appear in > "./configure --help" output. > > The autoconf documentation describes the distinction > between --with-PACKAGE and --enable-FEATURE, but since lokkit > is a package, and "lokkit-support" can be considered a feature of > libvirt, it's a little ambiguous. > > However, since autoconf gives the examples of "--with-x" and > "--with-gnu-as", "--with-lokkit" does seem to be more in line. Yep, I think we should use --with-lokkit since it also fits it a little better with the other --with-PROG args we already have - even though they don't all take a path as their optional arg (yet). Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list