On Mon, Jan 07, 2008 at 10:05:32AM +0000, Mark McLoughlin wrote: > On Sat, 2008-01-05 at 00:16 +0000, Daniel P. Berrange wrote: > > > Could we make the configure script a little more clever so that it is > > a tri-state and can auto-detect whether lokkit is available. > > > > - enable_iptables_lokkit=no - force disable > > - enable_iptables_lokkit=yes - check if it is supported, and error if not > > - enable_iptables_lokkit=check - check if it is supported and enable or disable as needed > > > > With 'check' being the default. This makes it 'do the right' thing by > > default, and lets the user have a strict override if neccessary. > > Okay, but that makes system-config-firewall a BuildRequires. > > (I'll fold the attached patch into this 7/9 patch) Great, looks good. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list