Re: PATCH: BZ 426425: Fix truncated reading of config files

["Richard W.M. Jones" <rjones@xxxxxxxxxx>]

Daniel P. Berrange wrote:
> The virConfReadFile  API  has a fixed 4096 byte buffer it reads the config
> file into, regardless of the config file size and silently drops any data
> exceeding this. 

Ah, the joys of C ...

> +    if ((ret = fread(*buf, st.st_size, 1, fh)) != 1) {
> +        free(buf);
> +        buf = NULL;

I wonder if you meant to write *buf = NULL here?

Rest of the patch +1

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list