"Richard W.M. Jones" <rjones@xxxxxxxxxx> wrote: > Daniel Veillard wrote: >> On Fri, Dec 07, 2007 at 11:19:27AM +0000, Richard W.M. Jones wrote: >>> This pulls in some extra modules that we need: >>> >>> sys_stat (provides things like the S_* permissions flags which are >>> missing under Windows) >>> >>> vasprintf (asprintf implementation) >>> >>> stdndup >>> >>> strsep >>> >>> poll >>> >>> gettext (portable gettext and <libintl.h> support) >>> >>> getpass (discussed previously) >> >> Looks fine to me, I assume you checked the LGPLv2 licence of the new >> modules imported from gnulib, good to see gnulib helps on many other >> portbility requirement than just the 2 initial cases, > > We already pull in LGPLv3 _header_ files (in CVS right now): > > float.in.h > intprops.h > physmem.h > stdlib.in.h > verify.h > > and a couple of LGPLv3 C files: > > dummy.c (but this file is literally trivial) > physmem.c > > (However the documentation for physmem says the module is under > LGPLv2+ so either the documentation is wrong or the top of the file is > wrong or else I don't understand what's going on here). > > Unfortunately although all the modules above are LGPLv2, I just > noticed that getpass depends indirectly on realloc. Documentation for > realloc says its LGPLv2+ so I didn't think it was a problem, but the > top of the file says LGPLv3. > > License lawyers, on your marks ... Don't worry. Perhaps gnulib-tool isn't transforming the licenses properly (yes, it is supposed to do this). physmem is most definitely LGPLv2+ because I just changed it. The definitive source is gnulib's modules/physmem file: License: LGPLv2+ I'm looking into why gnulib-tool isn't working as expected. -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list