On Tue, Dec 04, 2007 at 07:02:09PM +0000, Richard W.M. Jones wrote: > (1) #include <libvirt/*.h> ---> #include "libvirt/*.h" I was just wondering why, but looking at the patch yes, okay > (2) src/internal.h has become a dumping ground for all sorts of > includes. Removed the ones which are not actually used in this file > (ie. almost all of them) and moved them down into the two files which > actually needed them. > > (3) Remove <ansidecl.h>, which is apparently some legacy thing. > > (4) Add a comment that __func__ is from the C99 standard. > > (5) xen_unified.c was defining a symbol called 'VERSION' which clashed > with the one from "config.h", so change it to HV_VERSION. > > (6) <limits.h> / <sys/syslimits.h> / backup plan if neither exists -- is > done in src/internal.h, so remove explicit includes from other files. reviewed, all looks fine to me, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list