On Tue, Dec 04, 2007 at 05:39:17PM +0000, Richard W.M. Jones wrote:
> This patch removes checking for curses/ncurses. It is never used.
>
> It also allows libvirt to be compiled without readline support. If
> readline support is not available then the only difference is that
> 'virsh' will be built without it -- in other words, command line editing
> will not work in virsh.
Makes sense,
[...]
> +static char *
> +vshReadline (vshControl *ctl, const char *prompt)
> +{
> + char line[1024];
> + char *r;
> + int len;
> +
> + fputs (prompt, stdout);
> + r = fgets (line, sizeof line, stdin);
shouldn't we use parenthesis i.e. sizeof(line)
> + if (r == NULL) return NULL; /* EOF */
> +
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list