On Tue, Nov 20, 2007 at 03:19:42PM +0000, Richard W.M. Jones wrote:
> This code in qemu_driver.c doesn't look right to me. I think the second
> should be a call to brSetEnableSTP?
>
> Rich.
>
> if (network->def->forwardDelay &&
> (err = brSetForwardDelay(driver->brctl, network->bridge,
> network->def->forwardDelay))) {
> qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
> "failed to set bridge forward delay to %d\n",
> network->def->forwardDelay);
> goto err_delbr;
> }
>
> if ((err = brSetForwardDelay(driver->brctl, network->bridge,
> network->def->disableSTP ? 0 : 1))) {
> qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
> "failed to set bridge STP to %s\n",
> network->def->disableSTP ? "off" : "on");
> goto err_delbr;
> }
Yep, that second call is bogus. Guess no one has used this particular
functionality, or at least not noticed it ;-)
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list