Re: "make check" requires qemu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jim Meyering wrote:
So perhaps libvirt should BuildRequire qemu, too?

When I ran "make check" on a system without qemu,
I got lots of failures:

    ...
    QEMU XML-2-ARGV Misc ACPI                          ... FAILED
    libvir: QEMU error : Cannot find QEMU binary /usr/bin/qemu: No such file or directory
    QEMU XML-2-ARGV Misc No Reboot                     ... FAILED
    libvir: QEMU error : Cannot find QEMU binary /usr/bin/qemu: No such file or directory
    QEMU XML-2-ARGV Net User                           ... FAILED
    FAIL: qemuxml2argvtest

Here's a patch:

2007-10-17  Jim Meyering  <meyering@xxxxxxxxxx>

	* libvirt.spec.in (BuildRequires): Add "qemu".

Index: libvirt.spec.in
===================================================================
RCS file: /data/cvs/libvirt/libvirt.spec.in,v
retrieving revision 1.65
diff -u -p -r1.65 libvirt.spec.in
--- libvirt.spec.in	12 Oct 2007 19:54:15 -0000	1.65
+++ libvirt.spec.in	17 Oct 2007 10:11:33 -0000
@@ -25,6 +25,7 @@ BuildRequires: gnutls-devel
 BuildRequires: avahi-devel
 BuildRequires: dnsmasq
 BuildRequires: bridge-utils
+BuildRequires: qemu
 Obsoletes: libvir
 ExclusiveArch: i386 x86_64 ia64

Committed.  Thanks for your contributions to libvirt!

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]