On Wed, Sep 19, 2007 at 03:33:07AM +0100, Daniel P. Berrange wrote:
> On Tue, Sep 18, 2007 at 03:33:22AM -0400, Daniel Veillard wrote:
> > On Tue, Sep 18, 2007 at 02:32:59AM +0100, Daniel P. Berrange wrote:
> > >
> > > The current GNU TLS tests in the configure script just use CHECK_HEADER and
> > > CHECK_LIB to try and locate gnutls. This is fine if its in /usr, but no so
> > > useful if it is installed elsewhere. There are also no Makefile.am vars set
> > > to let you specify an alternate install location. gnutls already comes with
> > > support for pkg-config, so this patch just switches our configure script
> > > and Makefiles over to use that. Building against a different GNU TLS install
> > > is now just a matter of setting PKG_CONFIG_PATH, or the GNUTLS_LIBS and
> > > GNUTLS_CFLAGS vars.
> >
> > Same worry about pkg-config portability as for 1/5,
>
> Here's an updated version which uses pkg-config by default, but if that's
> not present uses the existing logic for CHECK_LIB.
Looks just fine too, thanks a lot !
+1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list