On Thu, Aug 16, 2007 at 09:27:04AM -0400, Daniel Veillard wrote: > On Thu, Aug 16, 2007 at 05:41:47PM +0900, Masayuki Sunou wrote: > > Hi > > > > When virsh attach-disk/attach-interface is executed in < Xen 3.0.4, > > the OS type of domain is NULL in xenDaemonAttachDevice(). > > As a result, the command becomes segmentation fault. > > > > This patch fixes it by checking the version of Xen in xenDaemonAttachDevice(). > > > > Signed-off-by: Masayuki Sunou <fj1826dm@xxxxxxxxxxxxxxxxx> > [...] > > > > + if (domain->id < 0 && priv->xendConfigVersion < 3) > > + return(-1); > > + > > str = virDomainGetOSType(domain); > > if (strcmp(str, "linux")) > > hvm = 1; > > I do not understand the patch. Why is that dependant on domain->id < 0 ? > Can you explain the logic there ? That just ensures that this command fails in a sensible way with inactive guests when run on older XenD without the inactive domain management APIs. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list