On Fri, Aug 10, 2007 at 12:08:26PM -0400, Daniel Veillard wrote: > On Fri, Aug 10, 2007 at 04:39:03PM +0100, Daniel P. Berrange wrote: > > The code for dealing with the paravirt framebuffer was missing code to deal > > with an explicit vncdisplay=N setting - only working for vncunused=1. It > > was also not flexible enough in processing the 2 different styles of FB > > config. > > I'm not sure I undertand the logic for setting the port, why going > whould xenstore there ? I'm not sure what you mean - xenstore isn't involved in this. This is for taking the XML and writing out the /etc/xen config - the port stuff is basically making sure that port="5903" is translated into the config option 'vncdisplay=3'. Previously only port="-1" was working. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list