On Wed, Jul 25, 2007 at 03:54:49PM +0100, Daniel P. Berrange wrote: > The test driver has suffered from quite alot of bitrot. Its got all sorts > of checks in the driver entry points already done by libvirt.c, its got > private data, redundantly pointing to private data, it doesn't implement > any of the networking APIs, is missing alot of the newer domain APIs. So > I've given it a thorough overhaul to remove alot of redundant code, clean > up more, and add entry points for all the APIs except for VCPU pinning ones. > > The addition of the networking APIs means we no longer get errors thrown > when trying to run tests without the libvirt daemon running, and means apps > can actually do tests for their networking capabilities. > > docs/testnetdef.xml | 12 > docs/testnetpriv.xml | 11 > docs/testnode.xml | 2 > src/driver.h | 1 > src/libvirt.c | 17 > src/qemu_driver.c | 1 > src/remote_internal.c | 1 > src/test.c | 1892 +++++++++++++++++++++++++++++++------------------- > tests/virshtest.c | 465 +++--------- > 9 files changed, 1382 insertions(+), 1020 deletions(-) Sounds good. That's a big patch, I looked (a bit quickly admitedly) and it looks fine, I think it's a good idea to add a name to network drivers too, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list