On Mon, Jul 23, 2007 at 04:26:07PM +0100, Richard W.M. Jones wrote: > This is a rolled up patch for virDomainMigrate, including virsh and > Python fixes. > > Changes since last time: > > - VIR_MIGRATE_LIVE is exported to Python > - 'resource' parameter is now named 'bandwidth' > - there is now an extra domainMigrateFinish step > > It needs a bit more testing which I can't do today while I'm at the office. yup, getting there. version 4 worked for me on my setup. > +typedef virDomainPtr > + (*virDrvDomainMigrateFinish) > + (virConnectPtr dconn, > + const char *dname, > + const char *cookie, > + int cookielen, > + const char *uri, > + unsigned long flags); > + Cool, yes, perfect. [...] > =================================================================== > RCS file: /data/cvs/libvirt/src/remote_internal.c,v > retrieving revision 1.15 > diff -u -p -r1.15 remote_internal.c > --- src/remote_internal.c 12 Jul 2007 15:17:08 -0000 1.15 > +++ src/remote_internal.c 23 Jul 2007 15:22:08 -0000 > @@ -1831,6 +1831,97 @@ remoteDomainDumpXML (virDomainPtr domain > } > > static int > +remoteDomainMigratePrepare (virConnectPtr dconn, > + char **cookie, int *cookielen, > + const char *uri_in, char **uri_out, > + unsigned long flags, const char *dname, > + unsigned long resource) there may be a couple of resource -> bandwidth changes lefts inside but it's minor. looks fine to me, I will try it tomorrow morning. thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list