On Fri, Jun 22, 2007 at 11:03:45AM +0100, Richard W.M. Jones wrote: > Jim Meyering wrote: > >"Richard W.M. Jones" <rjones@xxxxxxxxxx> wrote: > >>This small patch fixes some bugs in the handling of the field string > >>in virDomainGetSchedulerParameters and makes a similar pre-emptive fix > >>to virDomainSetSchedulerParameters. > >> > >>Also, please don't use !strcmp(a,b), because it confuses me. Better > >>is to write strcmp(a,b) == 0 to mean "strings match" and strcmp(a,b) > >>!= 0 to mean "strings don't match". > > > >Hi Rich, > > > >I agree, but prefer to avoid direct use of strcmp altogether. > >I use this definition: > > > > #define STREQ(a, b) (strcmp (a, b) == 0) > > > >Then all uses are either > > STREQ(a, b) or > > ! STREQ(a, b) > > Let's try this updated patch. +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/