On Thu, Jun 21, 2007 at 03:52:28PM +0100, Richard W.M. Jones wrote: > I've been going over the interface to libvirt, trying out every call > locally and remotely with all possible combinations of parameters that I > can think of. Not surprisingly one or two problems have cropped up. So > here's a short series of patches to fix the problems I've found. > > virConnectGetMaxVcpus has a second "type" parameter. In practice this > isn't used and can be passed as NULL. However that fails in the remote > case. The fix is simple enough -- attached. Looks fine to me in the sense I think I understand what the patch does, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/