On Mon, Jun 18, 2007 at 02:08:34PM +0100, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >This is a very big patch, but actually there is no real functional change > >in it at all. It is splitting the qemud_server struct into 2 pieces. The > >qemud_server struct now only deals with client/server socket stuff. The > >new qemud_driver struct deals with QEMU vms and networks. The driver.c > >and conf.c files are now 100% independant of the QEMU daemon, and so ready > >for the final adaption to the libvirt driver API. > > > > conf.c | 192 ++++++++--------- > > conf.h | 30 +- > > dispatch.c | 295 +++++++++++---------------- > > driver.c | 657 > > ++++++++++++++++++++++++++++++++++--------------------------- > > driver.h | 335 ++++++++++++++++++++++++++----- > > internal.h | 237 ---------------------- > > qemud.c | 50 ---- > > 7 files changed, 909 insertions(+), 887 deletions(-) > > That did lead me to wonder what happened to server->nvmfds - there are > two references to it in the code and both have been removed, but it > turns out it was only ever being written to, which I guess made it less > than useful. The nvmfds stuff was an optimization used with the old integrated event loop, which I forgot to remove in my first patch. It just let us know how big an array to allocate for poll_fd, which is unneccessary now that we have a general purpose isolated event loop. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|