On Mon, Jun 18, 2007 at 01:33:09PM +0100, Daniel P. Berrange wrote: > On Mon, Jun 18, 2007 at 05:49:59AM -0400, Daniel Veillard wrote: > > > - return ret; > > > + if (ret != 0) > > > + server->shutdown = 1; > > > } > > > > is asynchronous error handling really better there ? > > It is unavoidable in this context actually, since this is a callback > invoked from within the event loop, there isn't any meaningful caller > to deal with a return value. The event loop itself checks on the > server->shutdown flag on each iteration, so the end result is the > same as previous code. okay, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/