On Thu, Jun 14, 2007 at 06:58:06PM -0400, Mark Johnson wrote: > On 6/14/07, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > >On Thu, Jun 14, 2007 at 04:23:38PM -0400, Mark Johnson wrote: > >> This handles net-list, etc. a little more gracefully for Xen. > > > >I'm not so sure about this one. > > > > a. Xen does have support for net-list which is currently done via the > > (badly named) libvirt_qemud daemon. Though the network stuff would > > certainly require porting to Solaris for the bridge.c and the > > iptables.c files at the very least. > > We would probably have to write an separate implementation. > We use virtual NICs instead of a bridge and have a different > firewall/NAT. > > > > b. If the network driver isn't available - as with many other of the > > APIs - its standard practice for us to return a not implemented > > error. I think its important to keep this distinction between > > implemented, but no networks defined, vs not implemented at all. > > > >What end-application scenario were trying to address with these change ? > > > >I know virt-manager will complain once a second about the network functions > >if they return not implemented. This is on my list of things to fix in > >virt-manager though - once its tried once & found networking is unavailable > >it should stop trying & thus stop spewing warning messages after the first > >one. > > That's it. :-) It's was temporary fix until we could implement the network > functionality. Fixing virt-manager is better.. Please drop this patch, Agreed ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/