Re: [PATCH] setmem checks

"Richard W.M. Jones" <rjones@xxxxxxxxxx> · Fri, 15 Jun 2007 08:59:50 +0100

Mark Johnson wrote:
1673a1675,1677
    if (virDomainGetInfo(dom, &info) != 0) {
      info.maxMem = 0;
    }
1675c1679
<     if (kilobytes <= 0) {
---
    if ((kilobytes <= 0)  || (kilobytes > info.maxMem)) {

I don't understand this bit.  If virDomainGetInfo fails then it'll 
always give an error because kilobytes > info.maxMem (== 0) ?

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
Attachment:
smime.p7s

Description: S/MIME Cryptographic Signature