Re: [PATCH] Fix strange error message in virsh attach-device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 04, 2007 at 05:30:01PM +0900, Masayuki Sunou wrote:
> Hi Daniel
> 
> Thank you for your comment.
> 
> This patch changes about the following points.
> 
> >  buf.use = 0 means we are using 0 bytes of the buffer. That's the semantic
> > of buffer usage, if you really want to make it zero terminated, just use
> >        buf.content[0] = 0;
> >
> 1. This patch initializes the data with "buf.content[0] = 0".
> 
> >   use buf->use instead of strlen(buf.content)
> >
> 2. This patch checks the data size with "buf->use".

  Cool, thanks a lot !
Applied and commited to CVS,

  thanks again,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard@xxxxxxxxxx  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]