On Tue, 2007-05-22 at 20:32 +0100, Daniel P. Berrange wrote:
> On Tue, May 22, 2007 at 03:15:03PM +0100, Richard W.M. Jones wrote:
> >
> > I really think we should be looking at either a logging library, or
> > (better) syslog. These problems -- like logfile maxsize, logfile
> > location, log rotation -- have all been solved before, and I don't
> > believe we should reinvent this wheel.
> >
> > I'm keen to hear what others think though.
>
> I'm not convinced that virsh should have / needs persistent logging like
> this. The commands run via it really map straight onto individual APIs,
> and as such the error from any one command has no where near enough context
> to provide useful information.
I'm not convinced virsh needs this either:
- What other similar shell logs its errors/debug to a file?
- You generally want to see debug/error messages on stdout/stderr
when debugging something, rather than having to go poking in a
separate log file
e.g. the log won't be much good if I'm doing:
$> ssh markmc@foo virsh --debug 6 list
- Logging stuff to ~/.virsh is not something people will expect -
I'd imagine most people would be surprised to find a log file
- Log rotation, log file size, remote logging, log filtering etc.
are all solved problems ... let's not try and re-solve them
Cheers,
Mark.