Hi, > > I made the patch which output debug messages and error messages > > of virsh to the log file. > > I think that it is necessary to leave logs to the file for the > > investigation at the failure. > > Debug messages can take appointed optional information, > > and error messages will make it easy to specify a cause. > > Moreover, I'm thinking about outputting virterror information > > to the virsh log file by the next step. > > > > It is simple specifications as follows. > > * Destination -- <USER HOME>/.virsh/virsh.log > > * Log size -- 1MB(1024*1024) > > * Number of Rotations -- 5 > > * There is process exclusion. > > > > First, will you take in this patch ? > > Well, this patch looks OK to me. > > What would be wrong with just virsh ... 2>/tmp/logfile? Our team intends to let users use virsh as a part of the our team product. Therefore, it is not kind of to let users use redirection. When users use virsh, and an error occurred, our team wants to investigate it without letting users take trouble. > > And, I have a plan to enhance logging functionality. > > (for example, libvirt error logging) > > Can you explain? Because this patch cannot gather information of virterror yet, I plan to add the file output processing to error handler. Thanks, Nobuhiro Itou.