On Fri, May 11, 2007 at 11:15:29AM +0100, Richard W.M. Jones wrote: > Daniel Veillard wrote: > >On Thu, May 10, 2007 at 05:24:00PM +0100, Richard W.M. Jones wrote: > >>* Add some extra generated files to .cvsignore > >> > >>* Remove an unused header in qemud/uuid.c > >> > >>* Log an error if xenHypervisorOpen fails because xenHypervisorInit has > >>failed. > > > > just wondering about the last one, would that add a message if trying > >as non-root ? > > Yes it does, so that third patch is wrong. In fact xenHypervisorInit > already produces errors for all paths except the one where opening the > HV connection fails. Just make reporting the HV initialization error message conditional on getuid() == 0. We always want to see the error if root, and never if non-root. > OK to commit the first two? Yes. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|