On Tue, Apr 24, 2007 at 03:33:24PM +0100, Richard W.M. Jones wrote: > Kazuki Mizushima wrote: > >Hi all, > > > >I've been planing to adding cloning feature. > >Then, I tried to make the patch in the following way. > [...] > > Right - didn't see the patch the first time around ... > > I think the clone should be done as a libvirt call, rather than in > virsh. Adding stuff to virsh doesn't really help other libvirt users, > nor would it work in the remote case. If it goes into libvirt on the > other hand, then you get remote "for free" (in this case) and other > users of libvirt can implement it, in particular virt-manager. I disagree :-) I think cloning is a pretty high level operation and is better off outside the core libvirt API, building on top of the various APIs libvirt provides (or should provide). The most obvious set of missing APIs which are needed for clone are the storage management APIs we've discussed a few times in the past. Sooner or later we're going to have to tackle those APIs, since even regular guest provisioning will need them once we have remote support. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|