On Wed, Apr 18, 2007 at 10:38:17AM +0100, Richard W.M. Jones wrote:
> This minor patch:
>
> * Introduces a VIR_FROM_TEST class of errors and makes errors generated
> by test come from that class.
>
> * Provides a reasonable error message if the user forgets to supply a
> path. Also stops the driver from trying to open ("/"). Example:
> $ src/virsh -c test:/// capabilities
> libvir: Test error : invalid argument in testOpen: supply a
> path or use test:///default
> lt-virsh: error: failed to connect to the hypervisor
>
> * Arranges that Xen-unified appears last in the list of drivers, because
> qemu and test have well-defined URI syntaxes so can be checked first.
>
> 'make check' passes all tests with this patch.
looks fine by me, but I prefer fully parenthesized tests in conditions :-)
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/