On Wed, Feb 21, 2007 at 04:31:16PM +0000, Daniel P. Berrange wrote: > Because of the way Xen guest creation works, the virDomainCreateLinux > implementation for Xen is really a three stage process - first we create > the raw domain, then we have to wait for device hotplug to complete, > finally unpausing the domain. > > Currently if the device hotplug fails we error out, leaving a 'braindead' > VM lying around in the paused state. This is rather confusing for users > leading to people thinking everything was OK, and thus unpausing the > guest manually, then filing bug reports when they find they've no devices > in the guest VM ! Makes sense. I'm just not clear why code need to be moved from one function to another, but I'm lacking context ATM. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/