On Tue, Feb 20, 2007 at 09:55:28AM +0000, Mark McLoughlin wrote: > Hi, > Thanks for that ... > > On Tue, 2007-02-20 at 13:51 +0900, Atsushi SAKAI wrote: > > > > > - ((struct sockaddr_in *)&ifr.ifr_addr)->sin_family = AF_INET; > > > > - ((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr = inaddr; > > > > + ((struct sockaddr_in *)((void *)&ifr.ifr_addr))->sin_family = AF_INET; > > > > + ((struct sockaddr_in *)((void *)&ifr.ifr_addr))->sin_addr = inaddr; > > > bridge.c: In function 'brSetInetAddr': > > bridge.c:344: warning: cast increases required alignment of target type > > bridge.c:345: warning: cast increases required alignment of target type > > bridge.c: In function 'brGetInetAddr': > > bridge.c:381: warning: cast increases required alignment of target type > > - So, I think I'll go ahead and do it this way instead: > > - ((struct sockaddr_in *)&ifr.ifr_addr)->sin_family = AF_INET; > - ((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr = inaddr; > + ((struct sockaddr_in *)&ifr.ifr_data)->sin_family = AF_INET; > + ((struct sockaddr_in *)&ifr.ifr_data)->sin_addr = inaddr; I already committed Atsushi's original fix - so go ahead & overwrite it with this updated fix Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|