On Wed, Jan 31, 2007 at 10:27:10AM +0000, Richard W.M. Jones wrote: > Daniel P. Berrange wrote: > >On Fri, Jan 26, 2007 at 10:12:09AM -0500, Daniel Veillard wrote: > >>On Fri, Jan 26, 2007 at 03:02:01PM +0000, Richard W.M. Jones wrote: > >>>... or at least I can't see it being called anywhere. > >> It should probably, currently only xenHypervisorInit is hooked, > >>and we call it as part of the Open() ... that's not very clean though > >>I'm not sure it should be called directly from virInitialize() as we > >>may need only a subset of the available drivers in a given session. > > > >I don't see any particular need for a special 'init' method in the driver > >API - as you say the only impl is for xenHypervisorInit and that's called > >directly by the Open() as needed. So I vote for killing the 'init' driver > >method. > > If we just delete this method, are we breaking our commitment to > ABI-compatibility? A priori no, it should be completely internal, it's not an exported symbol. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/