On Fri, Jan 26, 2007 at 05:34:35AM -0500, Daniel Veillard wrote: > On Fri, Jan 26, 2007 at 02:58:27AM +0000, Daniel P. Berrange wrote: > > > > The attached patch adds two new commands to virsh: > > > > - console - connects to the guest's serial console > > - vncdisplay - outputs the ip address & port number of a guest vnc display Thanks! > > > > The former is another stage in eliminating the need to run 'xm' - replacing > > the Xen specific 'xm console' code, with the added advantage of working > > with any libvirt backend driver. > > Very cool. I wonder if we should not move out virsh specific code to > a new separate subdir, like for the proxy to clean things up a bit in src/ This is old kzak's idea :-) Yes, it's one large file, but it doesn't meen that we cannot split it to more files. The virsh.c file will be biger and biger. Karel -- Karel Zak <kzak@xxxxxxxxxx>