On Fri, Jan 26, 2007 at 10:12:09AM -0500, Daniel Veillard wrote: > On Fri, Jan 26, 2007 at 03:02:01PM +0000, Richard W.M. Jones wrote: > > > > ... or at least I can't see it being called anywhere. > > It should probably, currently only xenHypervisorInit is hooked, > and we call it as part of the Open() ... that's not very clean though > I'm not sure it should be called directly from virInitialize() as we > may need only a subset of the available drivers in a given session. I don't see any particular need for a special 'init' method in the driver API - as you say the only impl is for xenHypervisorInit and that's called directly by the Open() as needed. So I vote for killing the 'init' driver method. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|