On Tue, Jan 23, 2007 at 11:08:36AM +0000, Mark McLoughlin wrote: > On Mon, 2007-01-22 at 21:20 +0000, Daniel P. Berrange wrote: > > On Mon, Jan 22, 2007 at 02:46:11PM +0000, Mark McLoughlin wrote: > > > # Dan's patches > > > http://www.gnome.org/~markmc/code/libvirt-networking/libvirt-qemu-daemon.patch > > > http://www.gnome.org/~markmc/code/libvirt-networking/libvirt-qemu-driver.patch > > > > Now updated at: > > > > http://people.redhat.com/berrange/libvirt/libvirt-qemu-daemon-2.patch > > http://people.redhat.com/berrange/libvirt/libvirt-qemu-driver-2.patch > > Okay, I've updated my patch set to use them: > > http://www.gnome.org/~markmc/code/libvirt-networking/ > > One bug I found was that libvirt fails to connect if you don't have TLS > certs, even if the server doesn't request TLS. See attached patch. Ahhhh, yes that makes sense - i'd missed it because I always had the certs lieing in my working dir, even when testing without TLS. > > > http://www.gnome.org/~markmc/code/libvirt-networking/libvirt-qemu-no-c99.patch > > > > I simply removed -std=c99 and fixed up places I'd used C99 constructs, so should > > no longer be needed > > _XOPEN_SOURCE and _POSIX_C_SOURCE disable _SVID_SOURCE, so I still need > to enable that for struct ifreq and friends. Adding -D_SVID_SOURCE=1 is compiler args is no problem - its at least a fairly portable extension in comparison to turning on all GNU extensions. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|